Add descriptive error to name collision#46
Merged
devmotion merged 13 commits intoJuliaMath:mainfrom Oct 14, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 60 64 +4
=========================================
+ Hits 60 64 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 18492715480Details
💛 - Coveralls |
hz-xiaxz
changed the title
devmotion
reviewed
Oct 12, 2025
Contributor
Author
|
Thanks for your review! I've applied all suggestions. |
devmotion
reviewed
Oct 13, 2025
Contributor
Author
|
Done. |
devmotion
reviewed
Oct 13, 2025
hz-xiaxz
force-pushed
the
xxz/same-name
branch
from
b566c50 to
f0e9a02
Compare
devmotion
reviewed
Oct 14, 2025
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
Can you update the version number (again)?
Co-authored-by: David Müller-Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Müller-Widmann <devmotion@users.noreply.github.com>
devmotion
reviewed
Oct 14, 2025
Contributor
Author
|
Thanks a lot for the thorough review! I've learnt a lot as a Julia beginner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43. I'm not familiar with macro test so it's written with help of Gemini.